From 9be2b5d74806dcc4d4a4998328f424e69e23ad5a Mon Sep 17 00:00:00 2001 From: Erica Xu Date: Tue, 11 Jul 2023 11:37:36 -0400 Subject: [PATCH 1/4] Update manifest.json --- manifest.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/manifest.json b/manifest.json index 0897aff..624001a 100644 --- a/manifest.json +++ b/manifest.json @@ -1,5 +1,5 @@ { - "id": "obsidian-sample-plugin", + "id": "sample-plugin", "name": "Sample Plugin", "version": "1.0.0", "minAppVersion": "0.15.0", From e8f03522bc2ca211cc714b3b77beb6ed10ddaf12 Mon Sep 17 00:00:00 2001 From: Johannes Theiner Date: Mon, 17 Jul 2023 18:36:25 +0200 Subject: [PATCH 2/4] Adapt to plugin guidelines (#65) - remove header in settings - remove logging of changed settings value --- main.ts | 3 --- 1 file changed, 3 deletions(-) diff --git a/main.ts b/main.ts index 50b75f3..2d07212 100644 --- a/main.ts +++ b/main.ts @@ -120,8 +120,6 @@ class SampleSettingTab extends PluginSettingTab { containerEl.empty(); - containerEl.createEl('h2', {text: 'Settings for my awesome plugin.'}); - new Setting(containerEl) .setName('Setting #1') .setDesc('It\'s a secret') @@ -129,7 +127,6 @@ class SampleSettingTab extends PluginSettingTab { .setPlaceholder('Enter your secret') .setValue(this.plugin.settings.mySetting) .onChange(async (value) => { - console.log('Secret: ' + value); this.plugin.settings.mySetting = value; await this.plugin.saveSettings(); })); From 7112f01bc6e20f4d6884c71aa2ecf8f6f1f8e3c7 Mon Sep 17 00:00:00 2001 From: Lishid Date: Tue, 25 Jul 2023 15:17:26 -0400 Subject: [PATCH 3/4] Update README.md --- README.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 3e31368..bb0348e 100644 --- a/README.md +++ b/README.md @@ -49,7 +49,8 @@ Quick starting guide for new plugin devs: ## How to use - Clone this repo. -- `npm i` or `yarn` to install dependencies +- Make sure your NodeJS is at least v16 (`node --version`). +- `npm i` or `yarn` to install dependencies. - `npm run dev` to start compilation in watch mode. ## Manually installing the plugin From 8197fca0f7ac5f12416fa7cdeead0828e9e8dc5a Mon Sep 17 00:00:00 2001 From: SebastianMC <23032356+SebastianMC@users.noreply.github.com> Date: Tue, 26 Sep 2023 19:37:03 +0200 Subject: [PATCH 4/4] #89 - Support for multi-level sorting - minor fix --- src/custom-sort/custom-sort.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/custom-sort/custom-sort.ts b/src/custom-sort/custom-sort.ts index 82051bc..93268c1 100644 --- a/src/custom-sort/custom-sort.ts +++ b/src/custom-sort/custom-sort.ts @@ -529,13 +529,14 @@ export const determineFolderDatesIfNeeded = (folderItems: Array { if (item.folder) { - const folderDefaultSortRequiresFolderDate: boolean = !!(sortingSpec.defaultOrder && sortOrderNeedsFolderDates(sortingSpec.defaultOrder)) + const folderDefaultSortRequiresFolderDate: boolean = !!(sortingSpec.defaultOrder && sortOrderNeedsFolderDates(sortingSpec.defaultOrder, sortingSpec.defaultSecondaryOrder)) let groupSortRequiresFolderDate: boolean = false if (!folderDefaultSortRequiresFolderDate) { const groupIdx: number | undefined = item.groupIdx if (groupIdx !== undefined) { const groupOrder: CustomSortOrder | undefined = sortingSpec.groups[groupIdx].order - groupSortRequiresFolderDate = !!groupOrder && sortOrderNeedsFolderDates(groupOrder) + const groupSecondaryOrder: CustomSortOrder | undefined = sortingSpec.groups[groupIdx].secondaryOrder + groupSortRequiresFolderDate = !!groupOrder && sortOrderNeedsFolderDates(groupOrder, groupSecondaryOrder) } } if (folderDefaultSortRequiresFolderDate || groupSortRequiresFolderDate) {