tpl
/
obsidian-sample-plugin
Template
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

#74 - Integration with Bookmarks core plugin and support for indirect drag & drop arrangement 

- adjusted behavior of by-bookmark-comparator to adhere to the multi-level sorting support implemented in #89 and merged recently to this branch. Basically, each comparator is responsible only for its own comparison and should no fallback into other default comparisons - instead it should return 0, which indicates item which are equal from the perspective of the comparator
This commit is contained in:
SebastianMC 2023-09-19 15:50:42 +02:00
parent 527a03b050
commit 3c0cc70b03
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/custom-sort/custom-sort.spec.ts
View File

@ -2866,8 +2866,8 @@ describe('sorterByBookmarkOrder', () => {
[true,3,undefined,-1, 'a','a'], [true,3,undefined,-1, 'a','a'],
[true,undefined,4,1, 'b','b'], [true,undefined,4,1, 'b','b'],
[true,undefined,undefined,0, 'a','a'], [true,undefined,undefined,0, 'a','a'],
[true,undefined,undefined,-1, 'a','b'], [true,undefined,undefined,0, 'a','b'],
[true,undefined,undefined,1, 'd','c'], [true,undefined,undefined,0, 'd','c'],
[false,10,20,1, 'a', 'a'], [false,10,20,1, 'a', 'a'],
[false,20,10,-1, 'b', 'b'], [false,20,10,-1, 'b', 'b'],
[false,30,30,0, 'c', 'c'], // not possible in reality - each bookmark order is unique by definition - covered for clarity [false,30,30,0, 'c', 'c'], // not possible in reality - each bookmark order is unique by definition - covered for clarity
@ -2876,8 +2876,8 @@ describe('sorterByBookmarkOrder', () => {
[false,3,undefined,1, 'a','a'], [false,3,undefined,1, 'a','a'],
[false,undefined,4,-1, 'b','b'], [false,undefined,4,-1, 'b','b'],
[false,undefined,undefined,0, 'a','a'], [false,undefined,undefined,0, 'a','a'],
[false,undefined,undefined,1, 'a','b'], [false,undefined,undefined,0, 'a','b'],
[false,undefined,undefined,-1, 'd','c'], [false,undefined,undefined,0, 'd','c'],
])('straight order %s, comparing %s and %s should return %s for sortStrings %s and %s', ])('straight order %s, comparing %s and %s should return %s for sortStrings %s and %s',
(straight: boolean, bookmarkA: number|undefined, bookmarkB: number|undefined, order: number, sortStringA: string, sortStringB) => { (straight: boolean, bookmarkA: number|undefined, bookmarkB: number|undefined, order: number, sortStringA: string, sortStringB) => {