diff --git a/.npmrc b/.npmrc index b973752..77b64f6 100644 --- a/.npmrc +++ b/.npmrc @@ -1 +1,2 @@ -tag-version-prefix="" \ No newline at end of file +tag-version-prefix="" +legacy-peer-deps=true diff --git a/main.ts b/main.ts index 506c862..e912d60 100644 --- a/main.ts +++ b/main.ts @@ -1,11 +1,4 @@ -import { - App, - Notice, - Plugin, - PluginSettingTab, - Setting, - TFile, -} from 'obsidian'; +import { App, Plugin, PluginSettingTab, Setting, TFile } from 'obsidian'; import { FolderSuggest } from './src/suggestions/folderSuggest'; import { renderDonateButton } from './src/components/DonateButton'; import { diff --git a/src/services/file.service.ts b/src/services/file.service.ts index fcd63a5..a8fea77 100644 --- a/src/services/file.service.ts +++ b/src/services/file.service.ts @@ -78,6 +78,11 @@ export const renameFilesInObsidian = (app: App, plugin: BulkRenamePlugin) => { return; } + if (!plugin.settings.fileNames.length) { + new Notice('Please check your results before rename!'); + return; + } + new Notice('renaming has been started'); for (const fileName of plugin.settings.fileNames) { app.fileManager.renameFile(fileName, replaceFilePath(plugin, fileName)); diff --git a/src/services/file.services.test.ts b/src/services/file.services.test.ts index 42c1692..77575db 100644 --- a/src/services/file.services.test.ts +++ b/src/services/file.services.test.ts @@ -15,6 +15,9 @@ describe('File Services', () => { it.todo( 'should display notification if Existing Symbol match Replace Pattern', ); + it.todo( + "should throw an error if there files didn't reviewed before submit", + ); }); describe('Renaming', () => {