From b1f36156d19a042d42d6a30ff6b5cd07648138f0 Mon Sep 17 00:00:00 2001
From: SebastianMC <23032356+SebastianMC@users.noreply.github.com>
Date: Thu, 24 Aug 2023 00:28:24 +0200
Subject: [PATCH] Bugfix in sorterByMetadataField - reverse order working
 correctly now

- new unit tests
---
 src/custom-sort/custom-sort.spec.ts | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/src/custom-sort/custom-sort.spec.ts b/src/custom-sort/custom-sort.spec.ts
index b5ba6c6..7406c57 100644
--- a/src/custom-sort/custom-sort.spec.ts
+++ b/src/custom-sort/custom-sort.spec.ts
@@ -2254,6 +2254,25 @@ describe('CustomSortOrder.byMetadataFieldAlphabeticalReverse', () => {
 		expect(result1).toBe(SORT_FIRST_GOES_EARLIER)
 		expect(result2).toBe(SORT_FIRST_GOES_LATER)
 	})
+	it('should put the item with metadata later if the second one has no metadata (reverse order)', () => {
+		// given
+		const itemA: Partial<FolderItemForSorting> = {
+			metadataFieldValue: '15',
+			sortString: 'n123'
+		}
+		const itemB: Partial<FolderItemForSorting> = {
+			sortString: 'n123'
+		}
+		const sorter: SorterFn = Sorters[CustomSortOrder.byMetadataFieldAlphabeticalReverse]
+
+		// when
+		const result1: number = sorter(itemA as FolderItemForSorting, itemB as FolderItemForSorting)
+		const result2: number = sorter(itemB as FolderItemForSorting, itemA as FolderItemForSorting)
+
+		// then
+		expect(result1).toBe(SORT_FIRST_GOES_LATER)
+		expect(result2).toBe(SORT_FIRST_GOES_EARLIER)
+	})
 	it('should correctly fallback to alphabetical reverse if no metadata on both items', () => {
 		// given
 		const itemA: Partial<FolderItemForSorting> = {